perf(mounts): avoid array_merge in mounts loop #54968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Gaussorgues <[email protected]>
Altahrim
added
2. developing
Altahrim
requested review from
CarlSchwan,
leftybournes and
yemkareems
and removed request for
a team
Altahrim
added
3. to review
Collaborator
Author
|
/backport to stable32 |
come-nc
reviewed
Sep 9, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
I approve to put out the fire, but I think we should hunt for a prettier solution.
Also, I think the call to array_filter can be removed as I do not see where a falsy value could find its place in $mounts?
Can $event->getAdditionalMounts() return contain null values?
come-nc
approved these changes
Sep 9, 2025
Member
Better approach sounds fine, and merging for now so a RC2 deployment wouldn't "unpatch" a RC1+patch instance is the way to go. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintain two lists (one for
return, the other fornew SharedMount) to avoidarray_mergein loop.It can use a lot of CPU time:
