-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(Unified search): Use existing min search length setting #55259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Unified search): Use existing min search length setting #55259
Conversation
|
There is already such a setting in the legacy unified search component. Will investigate. Edit: I updated the code to reuse the existing config. |
627aee9 to
4f18962
Compare
4f18962 to
fa88d6e
Compare
|
/backport to stable32 |
|
/backport to stable31 |
fa88d6e to
12999ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non blocking, but ideally we should use the same sentence whether we have 0 or 1 char in the search field. The current proposal would result in a distracting flickering of the empty content string, unless it's debounced.
So from my pov either:
- say "Start typing to search" and don't change string when a char is added
- Keep proposed strategy but wait 1 sec before showing additional hint about the need of a second char. In this case the hint could be simplified as: "Type at least two characters to search"
12999ed to
1f1591e
Compare
Signed-off-by: Louis Chemineau <[email protected]>
This setting existed already for the legacy unified search. This commit expose that setting to the new front-end, and also ignore non valid requests in the backend. We also take the opportunity to register the config in the lexicon. Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
1f1591e to
c8370f3
Compare
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/55259/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 65d5bf20 fccb13e8 c8370f31
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55259/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/55259/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 65d5bf20 fccb13e8 c8370f31
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55259/stable32Error: Failed to push branch backport/55259/stable32: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport fccb13e to stable32 |
|
/backport fccb13e to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/55259/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fccb13e8
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55259/stable32Error: Failed to push branch backport/55259/stable32: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/55259/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fccb13e8
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55259/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This setting existed already for the legacy unified search.
This commit expose that setting to the new front-end, and also ignore non-valid requests in the backend.
We also take the opportunity to register the config in the lexicon.