-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(cache): Ensure unique global prefix per instanceid #55383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Marcel Müller <[email protected]>
934e0ca to
34a085d
Compare
|
/backport to stable32 |
|
Thanks, after applying the patch I can no longer reproduce the problem I had without it. |
fancycode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/55383/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 34a085d3
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55383/stable32Error: Failed to push branch backport/55383/stable32: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable32 |
|
Backlink to the same issue described in the forum. |
Yes please. |
Already done :) the quote is a command to trigger the backport (#55386). It’s already merged and will be included in the next release |
Thank you so much 🥇 .. Hopefully I can switch back to APCu again then |
Summary
Before this PR:
It's possible that instance 1 returns the key from instance 2 or vice versa
After this PR:
Key is correctly returned
Checklist
3. to review, feature component)stable32)