Skip to content

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Oct 14, 2025

Summary

Restrict which classes can be serialized by the DAV properties backend.

Checklist

@come-nc come-nc added this to the Nextcloud 33 milestone Oct 14, 2025
@come-nc come-nc requested a review from nickvergessen October 14, 2025 14:43
@come-nc come-nc self-assigned this Oct 14, 2025
@come-nc come-nc requested a review from a team as a code owner October 14, 2025 14:43
@come-nc come-nc added the 3. to review Waiting for reviews label Oct 14, 2025
@come-nc come-nc requested review from ArtificialOwl, leftybournes and yemkareems and removed request for a team October 14, 2025 14:43
@come-nc
Copy link
Contributor Author

come-nc commented Oct 14, 2025

/backport to stable32

@come-nc
Copy link
Contributor Author

come-nc commented Oct 14, 2025

The litmus tests need support for array type it seems:

23. propvalnspace......... 
23. propvalnspace......... FAIL (PROPPATCH of property with value defining namespace)
24. 
<- summary for `props': of 30 tests run: 29 passed, 1 failed. 96.7%

<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DAV\Exception</s:exception>
  <s:message>Property "{http://example.com/neon/litmus/}valnspace" has an invalid value of type array</s:message>
</d:error>

@come-nc come-nc force-pushed the fix/fix-property-objects-serialization branch 2 times, most recently from 80121df to a13c798 Compare October 16, 2025 09:42
@come-nc come-nc force-pushed the fix/fix-property-objects-serialization branch from a13c798 to 28c8ef1 Compare October 16, 2025 13:49
@nickvergessen nickvergessen mentioned this pull request Oct 17, 2025
11 tasks
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@come-nc come-nc merged commit 35f9d6f into master Oct 20, 2025
224 of 232 checks passed
@come-nc come-nc deleted the fix/fix-property-objects-serialization branch October 20, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants