fix(files_versions): Do not assume source exist when migrating versions to new storage #56117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
requested review from
Altahrim,
ArtificialOwl,
icewind1991 and
yemkareems
and removed request for
a team
artonge
added
3. to review
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
Altahrim
approved these changes
Nov 5, 2025
provokateurin
approved these changes
Nov 5, 2025
susnux
approved these changes
Nov 5, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
might be info level though
Contributor
Author
Given that this is unexpected and could highlight a data lost or an inconsistency between FS and DB, I think a warning is appropriate. |
…ns to new storage Signed-off-by: Louis Chmn <[email protected]>
artonge
force-pushed
the
artonge/fix/files_versions/do_not_assume_when_migrating
branch
from
9ca377d to
c1e151c
Compare
artonge
deleted the
artonge/fix/files_versions/do_not_assume_when_migrating
branch
This was referenced Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.