fix: pass only necessary information when deleting mulitple objects #56366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leftybournes
requested review from
CarlSchwan,
come-nc,
icewind1991 and
salmart-dev
and removed request for
a team
leftybournes
force-pushed
the
leftybournes/fix/s3_delete_folders
branch
from
dc1b482 to
eb44a50
Compare
Altahrim
approved these changes
Nov 12, 2025
provokateurin
approved these changes
Nov 12, 2025
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
Backport to stable31 is not necessary as the issue only occurs with stable32, which uses a more recent aws sdk version causing the issue. |
leftybournes
force-pushed
the
leftybournes/fix/s3_delete_folders
branch
2 times, most recently
from
e63824b to
08d1990
Compare
8 tasks
DeleteObjects currently fails when the request includes all the information returned by ListObjects. Send only the necessary information in the request. Note: 'Size' and 'DateModified' is now only supported by directory buckets. Signed-off-by: Kent Delante <[email protected]>
leftybournes
force-pushed
the
leftybournes/fix/s3_delete_folders
branch
from
08d1990 to
b57db10
Compare
Contributor
|
/backport to stable32 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/56366/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b57db108
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56366/stable32Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/56366/stable32."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeleteObjects currently fails when the request includes all the information returned by ListObjects. Send only the necessary information in the request. Note: 'Size' and 'DateModified' is now only supported by directory buckets.
Checklist
3. to review, feature component)stable32)