fix(core): RTL legacy snapper width #56425
Conversation
paulijar
requested review from
nfebe,
sorbaugh and
susnux
and removed request for
a team
|
/backport to stable31 |
|
/backport to stable32 |
susnux
changed the title
Note: Nextcloud version needs to be 31.0.10 or 32.0.1 or newer for the legacy snapper to work at all in th right-to-left layout. There's also a small bug related to the snapper width, see nextcloud/server#56425.
After ec9e283 there was still such a problem with the legacy app navigation snapper that its width was only 266 px on the RTL layout instead of the normal 300 px. The 266 px is the default width of Snap.js module. While the left side snapper width is configured with the property maxPosition, the right side snapper is configured by passing a negative value for the property minPosition. Signed-off-by: Pauli Järvinen <[email protected]>
susnux
force-pushed
the
fix/rtl-legacy-snapper-width
branch
from
6f59842 to
47f9407
Compare
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
After #55245 there was still such a problem with the legacy app navigation
snapper that its width was only 266 px on the RTL layout instead of the
normal 300 px. The 266 px is the default width of Snap.js module. While the
left side snapper width is configured with the property maxPosition, the right
side snapper is configured by passing a negative value for the property
minPosition.
Audio Player before:
Audio Player after:
(Effect is the same in the Music app but it doesn't yet have a published version with the RTL support.)
TODO
Checklist
3. to review, feature component)stable32)