fix(freebsd): fix cpu count for load graph #733
Conversation
ConstrictM
force-pushed
the
bugfix-freebsdcpuviewer
branch
from
2bd7827 to
a99fbf3
Compare
| $numCpu = intval($this->executeCommand('sysctl -n hw.ncpu')); //TODO: this should be tested if it actually works on FreeBSD | ||
| $numCpu = intval($this->executeCommand('/sbin/sysctl -n hw.ncpu')); | ||
| } catch (RuntimeException) { | ||
| return $numCpu; |
There was a problem hiding this comment.
| return $numCpu; |
Should be unnecessary since we're pre-initializing $numCpu and returning it anyhow at the end of the function, but also doesn't hurt. I see we're doing this elsewhere already so I guess leave it.
There was a problem hiding this comment.
That was my thought process. It should be consistent with the rest. Or all of the exception returns should be removed.
|
Can you edit your commit message? We're using conventional commits through more of our repositories these days. The requirement was recently activated here in this one too. |
Signed-off-by: Matthew Wener <[email protected]>
ConstrictM
force-pushed
the
bugfix-freebsdcpuviewer
branch
from
a99fbf3 to
61f1b20
Compare
ConstrictM
changed the title
|
/backport to stable30 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
3 participants
Follow-up for #711
Nextcloud version: 30.0.5
FreeBSD is showing "CPU info not available". The reason is the CPU count function is not calling the command correctly.
Fix Tested:
