Skip to content

Conversation

@tcitworld
Copy link
Member

Also add a condition on the lastLogin query for total number of users, just in case there's another app that uses this specific key

@tcitworld tcitworld added this to the Nextcloud 32 milestone Jun 4, 2025
@tcitworld tcitworld force-pushed the add-disabled-users-to-stats branch from f3795f0 to 5bcf3aa Compare June 4, 2025 10:08
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should rely on IUserManager::countDisabledUsers() instead of querying the DB

@tcitworld
Copy link
Member Author

Oops, forgot about this one. I'll might as well change countUserEntries to use IUserManager::countSeenUsers then.

@tcitworld tcitworld force-pushed the add-disabled-users-to-stats branch from 5bcf3aa to 4b9ef61 Compare June 5, 2025 15:49
@tcitworld tcitworld requested a review from come-nc June 5, 2025 15:50
@tcitworld tcitworld force-pushed the add-disabled-users-to-stats branch from 4b9ef61 to ed01f81 Compare June 5, 2025 15:51
And get the total number of users directly from IUserManager

Signed-off-by: Thomas Citharel <[email protected]>
@kesselb kesselb force-pushed the add-disabled-users-to-stats branch from ed01f81 to 744d70a Compare June 10, 2025 16:17
@kesselb kesselb enabled auto-merge June 10, 2025 16:17
@kesselb kesselb merged commit 326cc46 into master Jun 10, 2025
39 checks passed
@kesselb kesselb deleted the add-disabled-users-to-stats branch June 10, 2025 16:21
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants