fix(addContent): only process addExtensions once #6602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `editor.options.extensions`. This only includes the extensions that were configured when instantiating the editor. It does not include the extensions these extensions added. `generateJSON` will process the provided extensions and add extensions according to their `addExtensions` field. Before we used `editor.editorManager.extensions` which includes all extensions used in the editor including those added by other extensions. This lead to `generateJSON` adding the same extensions again which resulted in a warning. Signed-off-by: Max <[email protected]>
Collaborator
Author
|
/backport to stable30 |
Member
|
/backport to stable29 |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/6602/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ebaae962
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6602/stable29Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/6602/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ebaae962
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6602/stable30Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
editor.options.extensions.This only includes the extensions that were configured
when instantiating the editor.
It does not include the extensions these extensions added.
generateJSONwill process the provided extensionsand add extensions according to their
addExtensionsfield.Before we used
editor.editorManager.extensionswhich includes all extensions used in the editor
including those added by other extensions.
This lead to
generateJSONadding the same extensions againwhich resulted in a warning.