fix: Skip notifications for self mentions #6922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
fix/skip-self-mention
branch
from
aff3c2b to
2a55e54
Compare
jancborchardt
approved these changes
Feb 27, 2025
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Approving design-wise, not tested. Thanks a bunch @juliusknorr! :)
max-nextcloud
approved these changes
Feb 27, 2025
Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
force-pushed
the
fix/skip-self-mention
branch
from
2a55e54 to
3bd161c
Compare
github-project-automation
bot
moved this from 🏗️ At engineering
to 🎉 Done
in 🖍 Design team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed via chat with @jancborchardt we do not need a notification for self mentions an can just skip it