Skip to content

Conversation

@max-nextcloud
Copy link
Collaborator

@max-nextcloud max-nextcloud commented Apr 19, 2025

📝 Summary

Fixes Prettier warnings to prevent failures like:
https://github.com/nextcloud/text/actions/runs/14547996764/job/40815853006?pr=7063

🖼️ Screenshots

🏚️ Before 🏡 After
grafik grafik

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@max-nextcloud max-nextcloud requested a review from mejo- as a code owner April 19, 2025 09:54
@codecov
Copy link

codecov bot commented Apr 19, 2025

Codecov Report

Attention: Patch coverage is 53.44828% with 81 lines in your changes missing coverage. Please review.

Project coverage is 51.86%. Comparing base (e8e4635) to head (12bf89a).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/plugins/links.js 0.00% 9 Missing ⚠️
src/services/SessionApi.js 0.00% 9 Missing ⚠️
src/services/y-websocket.js 0.00% 9 Missing ⚠️
src/views/DirectEditing.vue 0.00% 8 Missing ⚠️
src/extensions/UserColor.js 0.00% 7 Missing ⚠️
src/nodes/Preview.js 0.00% 6 Missing ⚠️
src/nodes/TaskItem.js 0.00% 6 Missing ⚠️
src/nodes/CodeBlockView.vue 0.00% 5 Missing ⚠️
src/nodes/Image.js 0.00% 4 Missing ⚠️
src/nodes/ImageView.vue 0.00% 4 Missing ⚠️
... and 5 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7141   +/-   ##
=======================================
  Coverage   51.86%   51.86%           
=======================================
  Files         478      478           
  Lines       41460    41460           
  Branches     1003     1001    -2     
=======================================
  Hits        21503    21503           
  Misses      19852    19852           
  Partials      105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mejo- mejo- merged commit cdf4c23 into main Apr 29, 2025
66 checks passed
@mejo- mejo- deleted the test/prettier branch April 29, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants