Skip to content

Conversation

@JuliaKirschenheuter
Copy link
Contributor

Remove obsolete loading code from old API, add public shared id to enabled view

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot from 2025-04-30 17-32-13 Screenshot from 2025-04-30 17-11-40

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.75%. Comparing base (95160cd) to head (42093ca).
Report is 40 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7157      +/-   ##
==========================================
+ Coverage   51.83%   58.75%   +6.92%     
==========================================
  Files         479      478       -1     
  Lines       41488    36555    -4933     
  Branches     1002     1001       -1     
==========================================
- Hits        21504    21477      -27     
+ Misses      19879    14973    -4906     
  Partials      105      105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@szaimen
Copy link
Contributor

szaimen commented May 2, 2025

/backport to stable31

@szaimen szaimen added this to the Nextcloud 32 milestone May 2, 2025
@szaimen szaimen added the bug Something isn't working label May 2, 2025
@juliusknorr juliusknorr requested a review from a team May 5, 2025 10:32
@juliusknorr juliusknorr merged commit dd4fa6d into main May 5, 2025
70 checks passed
@juliusknorr juliusknorr deleted the fix/7088-Readme-not-shown-as-folder-description-on-public-share-links branch May 5, 2025 13:58
@juliusknorr
Copy link
Member

/backport to stable31

@juliusknorr juliusknorr mentioned this pull request May 5, 2025
10 tasks
@horvathcsabalaszlo
Copy link

Thanks :)

@skjnldsv
Copy link
Member

skjnldsv commented May 5, 2025

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Readme not shown as folder description on public share links

7 participants