[stable31] Refactor document status and menubar padding #7158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
force-pushed
the
backport/7130/stable31
branch
from
3f5dedb to
09da6c8
Compare
Move DocumentStatus into parent container to do so. Fixes stickyness of document status if editor does not have the full app content height, e.g. in Collectives or Deck. Signed-off-by: Jonas <[email protected]>
Fixes stickyness of menubar when editor does not have the full app height, e.g. in Collectives and Deck. Fixes: nextcloud/collectives#1704 Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
backport/7130/stable31
branch
4 times, most recently
from
2bd4c81 to
26c48a9
Compare
Signed-off-by: Jonas <[email protected]>
Fixes "[Vue warn]: Property or method "lock" is not defined on the instance but referenced during render." Signed-off-by: Jonas <[email protected]>
Make sure that document status and collision resolve dialog stay visible when scrolling down long documents. Signed-off-by: Jonas <[email protected]>
…overflow Signed-off-by: Jonas <[email protected]>
Use flexbox layout instead of height `100%` to avoid issues where editor is embedded into other apps and doesn't take full height. Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
We want the border to separate document content and menubar. So when we display the menubar at the bottom on mobile, the menubar border should be on top, not bottom of it. Signed-off-by: Jonas <[email protected]>
I spent some time trying to figure out where the extra 8px came from that created the scrollbar even with short content on mobile. In the end this seems like an acceptable workaround for now. Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
backport/7130/stable31
branch
from
26c48a9 to
edc1272
Compare
mejo-
approved these changes
Apr 30, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stable31 #7158 +/- ##
============================================
+ Coverage 51.84% 51.89% +0.05%
============================================
Files 287 287
Lines 40853 40904 +51
Branches 794 794
============================================
+ Hits 21182 21229 +47
- Misses 19550 19554 +4
Partials 121 121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7130