feat(link): Toggle link on selection with Mod-K shortcut #7188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acts only upon selection as inserting a link with empty title creates an invisible link, resulting in bad user experience in the WYSIWYG editor. Fixes: #7152 Signed-off-by: Jonas <[email protected]>
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Office team
mejo-
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Office team
Member
Author
|
/backport to stable31 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7188 +/- ##
==========================================
+ Coverage 52.41% 52.51% +0.10%
==========================================
Files 479 479
Lines 41508 41545 +37
Branches 1024 1024
==========================================
+ Hits 21757 21819 +62
+ Misses 19649 19624 -25
Partials 102 102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
luka-nextcloud
approved these changes
May 8, 2025
Contributor
|
I've tested and it works well 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acts only upon selection as inserting a link with empty title creates an invisible link, resulting in bad user experience in the WYSIWYG editor.
Fixes: #7152
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)