Skip to content

fix(files): Add smooth animation via clicking on heading #7197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mejo- merged 1 commit into from
Jun 20, 2025
Merged

fix(files): Add smooth animation via clicking on heading #7197

mejo- merged 1 commit into from
Jun 20, 2025

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented May 6, 2025

📝 Summary

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this May 6, 2025
@codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 58.97%. Comparing base (865a88f) to head (f754128).
Report is 177 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Editor/TableOfContents.vue 0.00% 3 Missing ⚠️
src/plugins/headingAnchor.js 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7197      +/-   ##
==========================================
+ Coverage   51.85%   58.97%   +7.12%     
==========================================
  Files         479      482       +3     
  Lines       41580    37117    -4463     
  Branches     1002     1048      +46     
==========================================
+ Hits        21561    21891     +330     
+ Misses      19914    15124    -4790     
+ Partials      105      102       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review May 8, 2025 13:53
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/6974-Maybe-have-an-animation-for-scrolling-to-the-heading-once-clicked branch from 5944b1a to 7ebc209 Compare May 8, 2025 13:54
max-nextcloud
max-nextcloud approved these changes May 8, 2025
View reviewed changes
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works for me. Code changes also seem fine.

@mejo-
Copy link
Member

mejo- commented May 8, 2025

Mhh, interesting. For me, this PR breaks anchor links. Whenever I click on the # next to a heading, it scrolls back to the beginning of the document.

@mejo-
Copy link
Member

mejo- commented May 8, 2025

Mhh, interesting. For me, this PR breaks anchor links. Whenever I click on the # next to a heading, it scrolls back to the beginning of the document.

It doesn't scroll back to the top of the document, but scrolls the clicked heading into the middle of the screen if possible. I guess that's a bit counter-intuitive and I would expect the heading to scrolled to the top of the editor container.

mejo-
mejo- requested changes May 8, 2025
View reviewed changes
mejo-
mejo- reviewed May 8, 2025
View reviewed changes
mejo-
mejo- reviewed May 8, 2025
View reviewed changes
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as draft June 6, 2025 06:50
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/6974-Maybe-have-an-animation-for-scrolling-to-the-heading-once-clicked branch from 8c8b55b to dce5bd5 Compare June 10, 2025 17:39
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review June 10, 2025 17:40
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Jun 16, 2025

@mejo- Hi Jonas,

could you please look into this again? Thank you!

mejo-
mejo- reviewed Jun 17, 2025
View reviewed changes
@juliusknorr juliusknorr added the bug Something isn't working label Jun 18, 2025
@juliusknorr juliusknorr added this to the Nextcloud 32 milestone Jun 18, 2025
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/6974-Maybe-have-an-animation-for-scrolling-to-the-heading-once-clicked branch from dce5bd5 to 1ade190 Compare June 18, 2025 10:22
@mejo-
Copy link
Member

mejo- commented Jun 18, 2025

/backport to stable31

@mejo-
Copy link
Member

mejo- commented Jun 18, 2025

/backport to stable30

mejo-
mejo- approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier complains about prosemirror.css. Once this got resolved, it's ready to merge 😊

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/6974-Maybe-have-an-animation-for-scrolling-to-the-heading-once-clicked branch from 1ade190 to f754128 Compare June 20, 2025 13:07
@mejo-
Copy link
Member

mejo- commented Jun 20, 2025

The failing assistant cypress test seems unrelated. It also fails on other PRs.

@mejo- mejo- merged commit 2945b46 into main Jun 20, 2025
85 of 91 checks passed
@mejo- mejo- deleted the enh/6974-Maybe-have-an-animation-for-scrolling-to-the-heading-once-clicked branch June 20, 2025 15:44
This was referenced Jun 20, 2025
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@mejo- mejo- mejo- approved these changes

@emberfiend emberfiend Awaiting requested review from emberfiend

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

3. to review bug Something isn't working

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

Table of contents: Maybe have an animation for scrolling to the heading once clicked

6 participants

@JuliaKirschenheuter @mejo- @juliusknorr @max-nextcloud @skjnldsv