-
Notifications
You must be signed in to change notification settings - Fork 109
fix: adjust table width for better view #7200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjust table width for better view #7200
Conversation
mejo-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the collectives app it's important to have similar layout of edit and view mode, for as less friction as possible when toggling between the two. Therefore I would prefer to keep it as is.
|
@mejo- |
|
What do our designers think? Cc @marcoambrosini |
|
I think ideally we want to make the table full width at all times move this "buttons column" outside. Much like the "+" button and link preview button on the left side. When the screen is smaller and these don't fit, I don't mind the horizontal jump when switching modes. What's more unsettling are vertical jumps. But in this case, either way is fine from my pov. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
e6ed847 to
8d53d0d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7200 +/- ##
==========================================
+ Coverage 52.67% 59.58% +6.91%
==========================================
Files 487 486 -1
Lines 42237 37337 -4900
Branches 1098 1097 -1
==========================================
Hits 22247 22247
+ Misses 19883 14984 -4899
+ Partials 107 106 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: ailkiv <[email protected]> Signed-off-by: Max <[email protected]>
8d53d0d to
887d46b
Compare
|
pushed a small fix to make prettier happy. |

📝 Summary
This fix applies only to the view mode
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)