Skip to content

Conversation

@AIlkiv
Copy link
Contributor

@AIlkiv AIlkiv commented May 7, 2025

📝 Summary

This fix applies only to the view mode

🖼️ Screenshots

🏚️ Before 🏡 After
before_ after_

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@AIlkiv AIlkiv requested review from max-nextcloud and mejo- as code owners May 7, 2025 13:33
mejo-
mejo- previously requested changes May 7, 2025
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the collectives app it's important to have similar layout of edit and view mode, for as less friction as possible when toggling between the two. Therefore I would prefer to keep it as is.

@AIlkiv
Copy link
Contributor Author

AIlkiv commented May 7, 2025

@mejo-
I agree, but on the other hand, when viewing the page, it looks like an incorrect styles.

Perhaps this layout will be a compromise?
demo

@mejo-
Copy link
Member

mejo- commented May 7, 2025

What do our designers think? Cc @marcoambrosini

@marcoambrosini
Copy link
Member

I think ideally we want to make the table full width at all times move this "buttons column" outside. Much like the "+" button and link preview button on the left side.

When the screen is smaller and these don't fit, I don't mind the horizontal jump when switching modes. What's more unsettling are vertical jumps. But in this case, either way is fine from my pov.

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@juliusknorr juliusknorr added enhancement New feature or request design Experience, interaction, interface, … 2. developing labels Jun 4, 2025
@max-nextcloud max-nextcloud dismissed mejo-’s stale review July 2, 2025 08:04

got design green light from marco.

@max-nextcloud max-nextcloud force-pushed the fix/table-width-adjustment branch from e6ed847 to 8d53d0d Compare July 2, 2025 08:05
@codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.58%. Comparing base (e522c75) to head (887d46b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7200      +/-   ##
==========================================
+ Coverage   52.67%   59.58%   +6.91%     
==========================================
  Files         487      486       -1     
  Lines       42237    37337    -4900     
  Branches     1098     1097       -1     
==========================================
  Hits        22247    22247              
+ Misses      19883    14984    -4899     
+ Partials      107      106       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@max-nextcloud max-nextcloud force-pushed the fix/table-width-adjustment branch from 8d53d0d to 887d46b Compare July 2, 2025 08:58
@max-nextcloud
Copy link
Collaborator

pushed a small fix to make prettier happy.

@max-nextcloud max-nextcloud enabled auto-merge July 2, 2025 09:06
@max-nextcloud max-nextcloud merged commit 7500315 into nextcloud:main Jul 2, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing design Experience, interaction, interface, … enhancement New feature or request feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants