-
Notifications
You must be signed in to change notification settings - Fork 109
fix(links): Use custom link handling only for text-only links #7385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/backport to stable31 |
|
/backport to stable30 |
All other links inside the editor (like previews via reference widgets or links in mermaid diagrams) should be treated the standard way. Fixes: #7384 Signed-off-by: Jonas <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7385 +/- ##
==========================================
+ Coverage 52.67% 59.57% +6.90%
==========================================
Files 487 486 -1
Lines 42237 37342 -4895
Branches 1098 1097 -1
==========================================
Hits 22247 22247
+ Misses 19883 14989 -4894
+ Partials 107 106 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
max-nextcloud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense code-wise. Tested that it does not break previews in collectives. They still open in the same tab.
|
/backport to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/7385/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick e955bfdc
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7385/stable31Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/7385/stable31."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
All other links inside the editor (like previews via reference widgets or links in mermaid diagrams) should be treated the standard way.
Fixes: #7384
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)