Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Jul 11, 2025

Backport of #7418

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking so this does not get merged before we're sure it actually makes sense.

@codecov
Copy link

codecov bot commented Jul 12, 2025

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.46%. Comparing base (4c08ace) to head (4d330d5).
Report is 12 commits behind head on stable31.

Files with missing lines Patch % Lines
src/views/RichWorkspace.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           stable31    #7421      +/-   ##
============================================
+ Coverage     51.51%   58.46%   +6.94%     
============================================
  Files           290      289       -1     
  Lines         41171    36265    -4906     
  Branches        840      839       -1     
============================================
- Hits          21211    21203       -8     
+ Misses        19840    14943    -4897     
+ Partials        120      119       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: Max <[email protected]>
@max-nextcloud max-nextcloud force-pushed the backport/7418/stable31 branch from 34714cd to 4d330d5 Compare July 12, 2025 13:09
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green again, @skjnldsv approved and I did a sanity check on the code. So should be good to go.

@max-nextcloud max-nextcloud marked this pull request as ready for review July 12, 2025 13:32
@max-nextcloud max-nextcloud requested a review from mejo- as a code owner July 12, 2025 13:32
@max-nextcloud max-nextcloud merged commit 8bc207d into stable31 Jul 12, 2025
66 checks passed
@max-nextcloud max-nextcloud deleted the backport/7418/stable31 branch July 12, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants