-
Notifications
You must be signed in to change notification settings - Fork 109
[stable31] fix(files): workspace implementation #7421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0ce8e13 to
34714cd
Compare
max-nextcloud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking so this does not get merged before we're sure it actually makes sense.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable31 #7421 +/- ##
============================================
+ Coverage 51.51% 58.46% +6.94%
============================================
Files 290 289 -1
Lines 41171 36265 -4906
Branches 840 839 -1
============================================
- Hits 21211 21203 -8
+ Misses 19840 14943 -4897
+ Partials 120 119 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: skjnldsv <[email protected]> Signed-off-by: Max <[email protected]>
34714cd to
4d330d5
Compare
max-nextcloud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is green again, @skjnldsv approved and I did a sanity check on the code. So should be good to go.
Backport of #7418
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.