Several link bubble/preview fixes #7474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7474 +/- ##
==========================================
+ Coverage 59.72% 59.75% +0.02%
==========================================
Files 495 495
Lines 37725 37824 +99
Branches 1090 1090
==========================================
+ Hits 22531 22600 +69
- Misses 15087 15117 +30
Partials 107 107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Jonas <[email protected]>
We have a custom node for displaying images anyway. This fixes the cursor being a pointer in the preview images of preview links. Signed-off-by: Jonas <[email protected]>
Fixes: #1226 Signed-off-by: Jonas <[email protected]>
When initiating the editor extensions (i.e. in `addProseMirrorPlugins()`), `editor.contentComponent` is not yet available. So let's read it when we actually use it, when creating the tooltip in `LinkBubblePluginView`. Before, a new Vue instance was initiated for each `LinkBubbleView.vue` as the `parent` given to `VueRenderer()` was `undefined`. With this fix, `LinkBubbleView.vue` becomes a child component of the root editor Vue instance. Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
| type="tertiary" | ||
| @click="openLink(href)"> | ||
| <template #icon> | ||
| <OpenInNewIcon :size="20" /> |
Collaborator
There was a problem hiding this comment.
I looked for a different icon briefly as this does not always open in new... but i found nothing satisfying.
max-nextcloud
approved these changes
Jul 23, 2025
Signed-off-by: Jonas <[email protected]>
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
This was referenced Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
editor.contentComponentwhen it's readyScreenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)