fix/guest user dialog

[max-nextcloud]

Lots of fixes to the guest user dialog:

• Keep the session list up to date.
• Update the guest avatar right after changing the name.
• Ensure the avatars in the toggle are always round.
• Use avatar colors for logged in users.
• Wording "Edit guest name" -> "Enter your name".
• use NcInputField with disabled (loading) and success state.
• Fix border in popup when viewing as a logged in user.
• Use color max contrast for guest names.
• Use valid html (wrap <form> in <li> to use in <ul>)
• Use 30px size for avatars. Together with the 2px border they match the 34px. input height.
• Use the same avatar size in toggle and popup.
• Hide local client for guest users even if no guestname is set.

Screenshots

🏃 Action	🏚️ Before	🏡 After
Admin sees guest now with colors
Guest sees admin and form now without duplicate entry for themselves
Guest starts entering new name Now with NcInputField
Guest successfully changed name with feedback now
Afterwards admin sees... now with updated name and color. (used to use an outdated color and name)

[codecov]

Codecov Report

❌ Patch coverage is 89.65517% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.12%. Comparing base (bc7c8c9) to head (4f691ed).
⚠️ Report is 43 commits behind head on main.

Files with missing lines	Patch %	Lines
src/extensions/CollaborationCursor.ts	13.33%	13 Missing ⚠️
src/composables/useEditorMethods.ts	33.33%	6 Missing ⚠️
src/services/SyncService.ts	33.33%	4 Missing ⚠️
src/apis/connect.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7555      +/-   ##
==========================================
+ Coverage   53.45%   60.12%   +6.66%     
==========================================
  Files         502      502              
  Lines       43542    38566    -4976     
  Branches     1128     1128              
==========================================
- Hits        23277    23186      -91     
+ Misses      20157    15272    -4885     
  Partials      108      108              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[max-nextcloud]

/backport to stable31

[silverkszlo]

When I open a .md file in Files app and open the same file via public link in a private browser, the display of another editor/guest overlaps with another icon (in Firefox; but maybe that's intentional :*)):

[silverkszlo]

In SessionList.vue:

data() {
  return {
	  myName: '',
  }
},

myName is not being used anymore or yet.

[max-nextcloud]

When I open a .md file in Files app and open the same file via public link in a private browser, the display of another editor/guest overlaps with another icon (in Firefox; but maybe that's intentional :*)):

Yes... it's intentional. We show up to three users plus the people Icon. I see there's room for improvement 😉 - but I also have no simple idea of what else to do.

[max-nextcloud]

myName is not being used anymore or yet.

Great catch!

Turns out it was not used since it was introduce in drumroll 2019.
🙈

[marcoambrosini]

Nice improvements @max-nextcloud. Dropping a few design related comments:

• When the guest username is not defined, instead of the question mark I suggest we use a regular user icon

• In "Guest sees admin and form
  now without duplicate entry for themselves"

  • I would not show an input field, instead I would show a list item with avatar, the string "you", and a right align secondary "edit" button with pencil icon. Clicking that would activate the input.
  • The input field here should be horizontally aligned with the left icon and button, right now they're slightly misaligned

• In "Guest starts entering new name Now with NcInputField"

  • Once in edit mode, the icon here could be hidden and the input field could expand to the left
  • I think it would still be good to have a submit button in the same place as the edit one, otherwise it's a bit confusing. I'd make it also primary in this case and with the icon: check.

[max-nextcloud]

Dropping a few design related comments:

I think I addressed them all. Let me know if I misunderstood something or something else comes up

Bildschirmaufzeichnung.vom.2025-08-24.12-30-33.mp4

[silverkszlo]

Also not related to this PR but $userName in SessionService.php does not seem to be used anymore or yet:
$userName = $this->userId ?? $guestName;

[silverkszlo]

In Editor.vue seems to be a typo in props. Should be required instead of require:

props: {
  richWorkspace: {
	  type: Boolean,
	  require: false,
	  default: false,
},