Migrate to outline Material Symbol style #7605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyScherzinger
requested review from
max-nextcloud and
mejo-
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7605 +/- ##
==========================================
+ Coverage 53.03% 59.80% +6.77%
==========================================
Files 503 502 -1
Lines 43718 38765 -4953
Branches 1129 1128 -1
==========================================
- Hits 23186 23184 -2
+ Misses 20423 15473 -4950
+ Partials 109 108 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
max-nextcloud
requested changes
Sep 4, 2025
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
One small issue - but it causes the linter to fail - so needs to be resolved.
Other than that good to go from my side.
| import MDI_TranslateVariant from 'vue-material-design-icons/TranslateVariant.vue' | ||
| import MDI_TrashCan from 'vue-material-design-icons/TrashCan.vue' | ||
| import MDI_TranslateVariant from 'vue-material-design-icons/Translate.vue' | ||
| import MDI_TrashCan from 'vue-material-design-icons/TrashCanOutline.vue' |
Collaborator
There was a problem hiding this comment.
This is now imported twice. Once as MDI_Delete and once as MDI_TrashCan.
Could be imported once and exported twice or the use of one of the two could be changed to the other one.
Signed-off-by: Andy Scherzinger <[email protected]> Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
style/noid/outlineIcons
branch
from
e83a389 to
59e9d76
Compare
max-nextcloud
approved these changes
Sep 4, 2025
Member
Author
|
/backport to stable32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)