feat: add downloadCallback for Viewer handler #7889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7889 +/- ##
=======================================
Coverage 45.96% 45.96%
=======================================
Files 141 141
Lines 3964 3964
Branches 747 747
=======================================
Hits 1822 1822
Misses 1838 1838
Partials 304 304 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
silverkszlo
force-pushed
the
downloadcallback-from-viewer
branch
from
e5a85a0 to
841e594
Compare
Signed-off-by: silver <[email protected]>
Signed-off-by: silver <[email protected]>
silverkszlo
force-pushed
the
downloadcallback-from-viewer
branch
from
841e594 to
3a1cd92
Compare
juliusknorr
approved these changes
Nov 5, 2025
Collaborator
Author
|
/backport to stable32 please |
Collaborator
Author
|
/backport to stable31 please |
Collaborator
Author
|
/backport to stable30 please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR is related to this PR in Viewer and in combination they resolve this issue in customer-feature-requests.
Before:
When editing a markdown document online in files and download it from the editor/viewer without saving it manually, the last saved version is downloaded. The last saved version may not include what was just added/edited after the previous
saveoperation. So the downloaded file may differ from the file one sees online.Now:
Clicking on
Downloadnow triggers an automaticsaveoperation of the document. If the saving for some reason fails, the last saved version is still being downloaded.🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)