-
Notifications
You must be signed in to change notification settings - Fork 309
feat: add support for image helpers in nitro endpoints #1473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
danielroe
merged 14 commits into
nuxt:main
from
Afshar07:feat/helper-support-in-nitro-endpoints
Apr 4, 2025
Merged
feat: add support for image helpers in nitro endpoints #1473
danielroe
merged 14 commits into
nuxt:main
from
Afshar07:feat/helper-support-in-nitro-endpoints
Apr 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
reviewed
Sep 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1473 +/- ##
==========================================
- Coverage 63.01% 62.93% -0.08%
==========================================
Files 80 81 +1
Lines 3742 3772 +30
Branches 426 429 +3
==========================================
+ Hits 2358 2374 +16
- Misses 1356 1369 +13
- Partials 28 29 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…n-nitro-endpoints
…n-nitro-endpoints
…n-nitro-endpoints
pi0
reviewed
Mar 24, 2025
pi0
reviewed
Mar 24, 2025
pi0
reviewed
Mar 24, 2025
commit: |
danielroe
approved these changes
Apr 4, 2025
danielroe
added a commit
that referenced
this pull request
Jul 30, 2025
Co-authored-by: Daniel Roe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement image helper utilities usage in nitro endpoints, by adding image options and nitro compatible utils in server directory.
But to be honest, it's my first contribution and i might (probably am) mess with a wrong config, so, it will be so kind for anyone to point out if i have done anything wrong!
🔗 Linked issue
resolves #1447
resolves #1329
❓ Type of change
📚 Description
Add an utility on server folder and auto import it into nitro, and also write image options into a virtual path in nitro.
Set a boolean to check if the utility is used in nitro environment, if it is, ignore prerendering static images.