Skip to content

Conversation

@luc122c
Copy link
Contributor

@luc122c luc122c commented Oct 25, 2025

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds a new image provider: GitHub. This provider is purely for user's avatar images.

This is an extension of this PR in the nuxters repo. After messaging @danielroe I've brought the provider across into the main nuxt/image repo. I've made some small changes to satisfy the TypeScript compiler.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 25, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/image@1990

commit: 18ee298

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2025

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.03%. Comparing base (4de3656) to head (18ee298).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/runtime/providers/github.ts 0.00% 21 Missing and 1 partial ⚠️
src/provider.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1990      +/-   ##
========================================
- Coverage   7.08%   7.03%   -0.05%     
========================================
  Files         76      77       +1     
  Lines       3529    3552      +23     
  Branches     137     138       +1     
========================================
  Hits         250     250              
- Misses      3232    3254      +22     
- Partials      47      48       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@luc122c luc122c marked this pull request as ready for review October 25, 2025 21:24
@luc122c luc122c requested a review from danielroe as a code owner October 25, 2025 21:24
@danielroe danielroe merged commit 7efb6ef into nuxt:main Oct 28, 2025
7 checks passed
@github-actions github-actions bot mentioned this pull request Oct 28, 2025
@luc122c luc122c deleted the feat/provider-github branch October 28, 2025 15:05
@github-actions github-actions bot mentioned this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants