Skip to content

Conversation

@aaharu
Copy link
Contributor

@aaharu aaharu commented Oct 30, 2025

🔗 Linked issue

resolves #1886
resolves #1285
resolves #1365

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Some providers prioritize the value of the Accept HTTP header, causing the format option to fail.
I added the option to set a allowlist for formats in the provider's configuration.

@aaharu aaharu requested a review from danielroe as a code owner October 30, 2025 12:07
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 30, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/image@1996

commit: 4c0b60b

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.03%. Comparing base (6022fa8) to head (4c0b60b).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/provider.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1996   +/-   ##
=====================================
  Coverage   7.03%   7.03%           
=====================================
  Files         77      77           
  Lines       3567    3567           
  Branches     138     138           
=====================================
  Hits         251     251           
  Misses      3268    3268           
  Partials      48      48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! thank you ❤️

@danielroe danielroe changed the title Formats allow list fix(awsAmplify,vercel): allow customising format allow list Oct 30, 2025
@danielroe danielroe changed the title fix(awsAmplify,vercel): allow customising format allow list fix(awsAmplify,vercel): set allow list of formats for providers Oct 30, 2025
@danielroe danielroe merged commit bf866af into nuxt:main Oct 30, 2025
7 checks passed
This was referenced Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants