Skip to content

add Oneplus3 support #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tsterbak merged 3 commits into from
Dec 10, 2023
Merged

add Oneplus3 support #365

tsterbak merged 3 commits into from
Dec 10, 2023

Conversation

@SirRGB
Copy link
Contributor

@SirRGB SirRGB commented Nov 20, 2023

@SirRGB
Copy link
Contributor Author

SirRGB commented Nov 20, 2023

Needs #362 merged first to avoid conflicts

@tsterbak tsterbak added the enhancement New feature or request label Nov 22, 2023
tsterbak
tsterbak reviewed Nov 22, 2023
View reviewed changes
@tsterbak tsterbak added device Request to add or improve a specific device. and removed enhancement New feature or request labels Nov 22, 2023
@SirRGB SirRGB force-pushed the oneplus3 branch 2 times, most recently from 3824d43 to b2597ae Compare November 23, 2023 13:29
@SirRGB
add oneplus model names
b441f72 
* taken from gsmarena, wikipedia and the lineage wiki
@SirRGB
add motorola model names
2807c43 
* taken from the lineage wiki and https://telegra.ph/G5-Variants--Code-Names-10-07

Signed-off-by: SirRGB <[email protected]>
@SirRGB
add oneplus3 support
1df1dc5 
* asserts taken from https://github.com/LineageOS/android_device_oneplus_oneplus3/blob/e975bda0561217fae2a342c2e8c1848b3e3cf370/BoardConfig.mk#L35C29-L35C66
* copied config from cheeseburger

Signed-off-by: SirRGB <[email protected]>
@tsterbak
Copy link
Member

tsterbak commented Dec 1, 2023

Is this ready to be merged? Looks good to me :)

@MagicLike
Copy link
Member

MagicLike commented Dec 1, 2023

Is this ready to be merged? Looks good to me :)

As stated, #362 needs to merge first..,

MagicLike
MagicLike approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@MagicLike MagicLike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MagicLike MagicLike linked an issue Dec 1, 2023 that may be closed by this pull request
Add support for OnePlus3T #273
Closed
@tsterbak tsterbak merged commit eeac0b3 into openandroidinstaller-dev:dev Dec 10, 2023
@SirRGB SirRGB deleted the oneplus3 branch December 10, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsterbak tsterbak tsterbak left review comments

@MagicLike MagicLike MagicLike approved these changes

Assignees

No one assigned

Labels

device Request to add or improve a specific device.

Projects

None yet

Milestone

Release Beta-Version 0.5.2 - New Year...

Development

Successfully merging this pull request may close these issues.

Add support for OnePlus3T

3 participants

@SirRGB @tsterbak @MagicLike