-
Notifications
You must be signed in to change notification settings - Fork 33
Release v0.5.4-beta.1 #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is this related to #623? |
Yeah, I was hoping to fix it with release 0.5.4, but there seems to be an issue with flet version 0.24.1 (or I'm confused) and the flatpak fails to work. So I will try to go full flet 0.26.0 where it seems to be fixed. |
|
So this release will probably go out fast once I confirmed that the flatpak works this time. New devices can go right in ;) |
|
@SirRGB @MagicLike @freechelmi @BjornW I added some code to send the device code of started and successful installation attempts to an analytics service (plausible.io). This would be a direct way to collect usage information and what devices people use the installer with. And it would help my motivation to actually "see" people using the installer. What do you think about it? Would you (strongly?) oppose this? If your busy, a 👍 or 👎 would already help me 🙂 Edit: 👍 would indicate you are fine with collecting usage information, while 👎 would indicate the opposite (because it might be unclear from the text) |
This would be awesome, also even we could gather attempts on unsupported devices , this would help to focus on most popular devices to come. |
|
A bit (too?) late: I'm not a big fan of telemetry even though I can see the usefulness. Please make sure to clearly & explicitly explain this feature: why it has been added to the application, the purpose and the type of data collected. @tsterbak has something like this already been added to the website? |
Yeah, I'm also not a big fan usually. But it would help a lot to see what devices people use the installer with and if they are successful (or not). And it would help my motivation to actually "see" people using the installer. 😁 But yeah, maybe it will be removed again, lets see how it goes. |
|
Quick different question: |
|
Just ran the sargo test and didnt notice anything different. |
|
The test doesn't actually run anything its just for clicking through the frontend (if we are talking about the same thing). I noticed occasional issues with fastboot/adb and I'm not sure if it is my testing devices or the installer... (Points towards issues with the testing devices/cable/ports/drivers: in the state when the installer stops working, I can also not continue with non-installer adb/fastboot.) Yeah, I could make the whole statistics of the website and the installer events publicly available. I think I will add a link to the readme and the website under "Statistics". Or do you have another idea? |
|
Ic, Ive also ran through oai on my S5 Mini, to also close that weird issue I created at some point, so that should show up now ig. Maybe it is also possible to mention the "success rate" and "unlock/twrp" on the stats page, to see issues? I dont think we differentiate between "ended app" and "doesnt work" rn? |
@SirRGB I added a link to the collected statistics to the readme now. Have a look and maybe somethign is missing? |
|
I didnt spot the actual devices and their finish rate... |
You have to scroll to the bottom and then click on the finished event for example. Then you see the device codes. |
This release adds (actually, this release might be part of release 0.5.4 to fix the flatpak):
New devices:
Chores: