CI: migrate Vagrant + Cirrus to Lima + GHA #4664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AkihiroSuda
commented
Mar 6, 2025
AkihiroSuda
commented
- Unlike proprietary Vagrant, Lima remains to be an open source project
- GHA now natively supports nested virt on Linux runners
AkihiroSuda
force-pushed
the
lima-actions
branch
3 times, most recently
from
575844d to
8014f55
Compare
This comment was marked as resolved.
This comment was marked as resolved.
AkihiroSuda
force-pushed
the
lima-actions
branch
from
8014f55 to
75ec26d
Compare
rata
approved these changes
Mar 6, 2025
Member
rata
left a comment
rata
left a comment
There was a problem hiding this comment.
This LGTM, left one question about the instance size
- Unlike proprietary Vagrant, Lima remains to be an open source project - GHA now natively supports nested virt on Linux runners Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
lima-actions
branch
from
75ec26d to
135552e
Compare
lifubang
approved these changes
Mar 7, 2025
rata
reviewed
Mar 7, 2025
Comment on lines
+233
to
+236
| # CPUs: min(4, host CPU cores) | ||
| # RAM: min(4 GiB, half of host memory) | ||
| # Disk: 100 GiB | ||
| run: limactl start --plain --name=default template://fedora |
Member
There was a problem hiding this comment.
lima autodetects mem and CPU, then?
Member
Author
There was a problem hiding this comment.
Member
|
@AkihiroSuda the fedora test didn't start, so I can't merge. Can you repush to see if that is all or if it is somehow related to this PR? |
Contributor
|
The fedora test (on Cirrus CI) is being removed as part of this PR (replaced with fedora on gha). I will modify CI reqs and merge. |
This was referenced Mar 8, 2025
AkihiroSuda
added
backport/1.2-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
