ci: Check for exclude/replace directives #4750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rata
force-pushed
the
go-mod-exclude-linter
branch
2 times, most recently
from
ab9162c to
182ddeb
Compare
Member
Author
|
It fails as expected now :) |
rata
force-pushed
the
go-mod-exclude-linter
branch
from
182ddeb to
e06dc93
Compare
Member
Author
|
Rebased now that is merged |
cyphar
approved these changes
Apr 29, 2025
AkihiroSuda
reviewed
Apr 30, 2025
To not accidentally break `go install`, let's add CI to check it. If in the future we need those directives, we can remove the CI check. Signed-off-by: Rodrigo Campos <[email protected]>
rata
force-pushed
the
go-mod-exclude-linter
branch
from
e06dc93 to
9f86496
Compare
Member
Author
|
@AkihiroSuda PTAL |
AkihiroSuda
approved these changes
Apr 30, 2025
Contributor
|
One other way to do that is to remove exclude/replace when opening release branches. For example, this is what gopls does: golang/go#42627 / https://go-review.googlesource.com/c/tools/+/272688. In their master branch, there's a We don't have to do the same thing here because we don't have multiple inter-dependent go.mod files in the same repository, but moby/sys might actually benefit from this trick (this will result in more git noise and complicated releases but simpler CI). Cc @thaJeztah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To not accidentally break
go install, let's add CI to check it. If in the future we need those directives, we can remove the CI check.This should only be merged after #4748, as we are currently using an exclude directive.