[a11y] Move server URL from status label to Account button #11810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 19, 2024
erikjv
force-pushed
the
work/move-server-url
branch
from
bb67bc0 to
feaf129
Compare
TheOneRing
reviewed
Aug 22, 2024
TheOneRing
suggested changes
Aug 22, 2024
Contributor
TheOneRing
left a comment
TheOneRing
left a comment
There was a problem hiding this comment.
^
Looks great, but I think we can clean it up, please correct me if I'm wrong.
erikjv
force-pushed
the
work/move-server-url
branch
from
feaf129 to
4cbde2f
Compare
erikjv
force-pushed
the
work/move-server-url
branch
from
4cbde2f to
5ca4ebc
Compare
TheOneRing
previously approved these changes
Aug 28, 2024
erikjv
force-pushed
the
work/move-server-url
branch
from
5ca4ebc to
6713cb0
Compare
TheOneRing
reviewed
Aug 28, 2024
erikjv
force-pushed
the
work/move-server-url
branch
from
6713cb0 to
169e88f
Compare
TheOneRing
approved these changes
Aug 28, 2024
erikjv
force-pushed
the
work/move-server-url
branch
from
169e88f to
64d9f12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL in the status label of the account settings page was not always accessible by keyboard. The label will now only show the connection status, and the "Manage Account" button has a new entry for "Open in Web Browser".