[DC-146, DC-166] Fix VFS checkbox in folder wizard #12305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
On the last page of the folder wizard, there is a checkbox to select/deselect VFS. By default this is checked. The bug was that after unchecking this checkbox, it could not be checked again. This has now been fixed.
modSpike
reviewed
Sep 12, 2025
Contributor
Author
|
I also need to fix https://kiteworks.atlassian.net/browse/DC-166 (Add folder wizard: when VFS is forced on, the selective sync page is still shown) |
Previously the checkbox to deselect VFS was not shown when VFS was forced. This also caused the selective sync widget to be enabled. This is now fixed: the checkbox is shown (and checked) when VFS is availabled, but disabled when VFS is forced. This leaves it in the checked state, but the user cannot deselect it.
erikjv
changed the title
erikjv
added a commit
that referenced
this pull request
Sep 19, 2025
* [DC-146] Fix VFS checkbox in folder wizard On the last page of the folder wizard, there is a checkbox to select/deselect VFS. By default this is checked. The bug was that after unchecking this checkbox, it could not be checked again. This has now been fixed. * Move checkbox handling to a slot * [DC-166] Disable selective-sync when VFS is forced Previously the checkbox to deselect VFS was not shown when VFS was forced. This also caused the selective sync widget to be enabled. This is now fixed: the checkbox is shown (and checked) when VFS is availabled, but disabled when VFS is forced. This leaves it in the checked state, but the user cannot deselect it. --------- Co-authored-by: modSpike <[email protected]> (cherry picked from commit 73493d0)
erikjv
added a commit
that referenced
this pull request
Sep 19, 2025
* [DC-146] Fix VFS checkbox in folder wizard On the last page of the folder wizard, there is a checkbox to select/deselect VFS. By default this is checked. The bug was that after unchecking this checkbox, it could not be checked again. This has now been fixed. * Move checkbox handling to a slot * [DC-166] Disable selective-sync when VFS is forced Previously the checkbox to deselect VFS was not shown when VFS was forced. This also caused the selective sync widget to be enabled. This is now fixed: the checkbox is shown (and checked) when VFS is availabled, but disabled when VFS is forced. This leaves it in the checked state, but the user cannot deselect it. --------- Co-authored-by: modSpike <[email protected]> (cherry picked from commit 73493d0)
DeepDiver1975
added a commit
that referenced
this pull request
Sep 25, 2025
* [DC-146, DC-166] Fix VFS checkbox in folder wizard (#12305) * [DC-146] Fix VFS checkbox in folder wizard On the last page of the folder wizard, there is a checkbox to select/deselect VFS. By default this is checked. The bug was that after unchecking this checkbox, it could not be checked again. This has now been fixed. * Move checkbox handling to a slot * [DC-166] Disable selective-sync when VFS is forced Previously the checkbox to deselect VFS was not shown when VFS was forced. This also caused the selective sync widget to be enabled. This is now fixed: the checkbox is shown (and checked) when VFS is availabled, but disabled when VFS is forced. This leaves it in the checked state, but the user cannot deselect it. --------- Co-authored-by: modSpike <[email protected]> (cherry picked from commit 73493d0) * fix: compiler error --------- Co-authored-by: modSpike <[email protected]> Co-authored-by: Thomas Müller <[email protected]>
DeepDiver1975
added a commit
that referenced
this pull request
Oct 1, 2025
* [DC-146] Fix VFS checkbox in folder wizard On the last page of the folder wizard, there is a checkbox to select/deselect VFS. By default this is checked. The bug was that after unchecking this checkbox, it could not be checked again. This has now been fixed. * Move checkbox handling to a slot * [DC-166] Disable selective-sync when VFS is forced Previously the checkbox to deselect VFS was not shown when VFS was forced. This also caused the selective sync widget to be enabled. This is now fixed: the checkbox is shown (and checked) when VFS is availabled, but disabled when VFS is forced. This leaves it in the checked state, but the user cannot deselect it. --------- (cherry picked from commit 73493d0) Co-authored-by: modSpike <[email protected]> Co-authored-by: Thomas Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the last page of the folder wizard, there is a checkbox to select/deselect VFS. By default this is checked. The bug was that after unchecking this checkbox, it could not be checked again.