BUG: pd.unique(Index) now returns Index as Index.unique #57679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like CI failures are not related. Could you please review this PR? @rhshadrach |
rhshadrach
requested changes
Mar 8, 2024
Member
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
Thanks for the PR! Some questions / requests.
pandas/tests/test_algos.py
Outdated
| # GH#57043 | ||
| index = index.repeat(2) | ||
| result = algos.unique(index) | ||
| expected = index.unique() |
Member
There was a problem hiding this comment.
Is it doable to specify expected explicitly here instead of using index.unique()?
Contributor
Author
There was a problem hiding this comment.
I think we can adapt the test from
pandas/pandas/tests/base/test_unique.py
Line 12 in 4692686
Contributor
Author
|
Thank you for the review. I push a new commit to address the requests. @rhshadrach |
rhshadrach
reviewed
Mar 9, 2024
rhshadrach
approved these changes
Mar 12, 2024
Member
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
lgtm, wouldn't mind another eye @mroeschke
mroeschke
approved these changes
Mar 12, 2024
mroeschke
added
Algos
Member
|
Thanks @yuanx749 |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…7679) * Add test * Fix * Adjust tests * Add whatsnew * Improve tests * Remove duplicate test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some old tests are adjusted for consistency.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.