Tkinter binding involving Control-spacebar raises unicode error

[kbkaiser]

BPO	1028
Nosy	@terryjreedy, @kbkaiser, @vstinner, @ned-deily, @bitdancer, @codeape2
Files	tkintertest.py _tkinter.c.patch PythonCmd_check_for_utf.diff just_for_explanation.patch issue1028.diff adjusts1.diff issue1028_2.diff _tkinter.c.2.patch: Convert 0xC080 to 0x00

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/kbkaiser'
closed_at = <Date 2011-05-11.21:20:52.642>
created_at = <Date 2007-08-26.20:48:31.672>
labels = ['expert-IDLE', 'type-bug', 'expert-tkinter', 'expert-unicode']
title = 'Tkinter binding involving Control-spacebar raises unicode error'
updated_at = <Date 2012-06-05.02:30:35.417>
user = 'https://github.com/kbkaiser'

bugs.python.org fields:

activity = <Date 2012-06-05.02:30:35.417>
actor = 'Mike.Perry'
assignee = 'kbk'
closed = True
closed_date = <Date 2011-05-11.21:20:52.642>
closer = 'kbk'
components = ['IDLE', 'Tkinter', 'Unicode']
creation = <Date 2007-08-26.20:48:31.672>
creator = 'kbk'
dependencies = []
files = ['8323', '8330', '12054', '12094', '14674', '14675', '14677', '21954']
hgrepos = []
issue_num = 1028
keywords = ['patch', 'needs review']
message_count = 45.0
messages = ['55311', '55312', '55313', '55321', '55325', '55330', '75999', '76032', '76034', '76035', '76041', '76043', '76164', '76165', '76173', '76178', '76179', '76180', '76701', '76846', '77209', '81060', '81989', '90665', '90707', '91405', '91408', '91420', '92678', '99441', '101508', '110080', '116773', '118400', '128441', '133494', '135707', '135788', '135795', '135806', '135807', '153250', '153252', '161718', '162321']
nosy_count = 11.0
nosy_names = ['terry.reedy', 'kbk', 'vstinner', 'ned.deily', 'r.david.murray', 'Bernt.R\xc3\xb8skar.Brenna', 'BreamoreBoy', 'jsprunck', 'mgstrein', 'python-dev', 'Mike.Perry']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue1028'
versions = ['Python 3.2', 'Python 3.3']

[kbkaiser]

The control-spacebar binding is used in IDLE to
force open the completions window. It's causing
IDLE to exit with a utf8 decode error. Attached
is
a Tkinter cut-down
exhibiting the problem and a patch.

The cutdown runs ok on 2.6 but not on py3k because
the latter uses PyUnicode_FromString on all the
arguments and errs out when it encounters a
character outside the utf-8 range.

Strangely, on my system, control-spacebar is
sending a two byte
string, C0E8 via the %A parameter. Control-2
does
the same. Other keys with combinations of
modifier
keys send one byte.

Linux trader 2.6.18-ARCH #1 SMP PREEMPT Sun Nov
19
09:14:35 CET 2006 i686 Intel(R) Pentium(R) 4 CPU
2.40GHz GenuineIntel GNU/Linux

Can the problem be confirmed?

Using PyUnicode_FromUnicode on %A works because
the
unicode string is copied instead of decoded, and
that parameter is supposed to be unicode, in any
case.

The patch fixes the problem on my system but
should
be reviewed, especially whether the cast in the
call
to PyUnicode_FromUnicode is suitably cross-
platform.

Assigning to Neal since he's working a lot of
Unicode issues right now. I can check it in if I
get approval.

[kbkaiser]

Heh, I see we have the same damn problem SF had: when a comment is
edited,
it doesn't re-wrap properly when submitted. You have to remove the
returns
manually after editing.

[kbkaiser]

Nope, you have to make sure not to type too wide.

[kbkaiser]

Well, maybe someday Tk will send a multibyte unicode
character. Update the patch.

[nnorwitz]

I can confirm the problem and that your patch fixes the problem. Go
ahead and check it in. Thanks!

[kbkaiser]

OK, thanks for the review! I suppose Tk is sending a bad string.
r57540

[ocean-city]

Sorry, I reverted r57540 because it caused segfault at IDLE exit. (See
bpo-4313) I reopened this issue.

[gpolo]

I can reproduce it here with tk8.4, using tk8.5 doesn't cause this.

[gpolo]

Here is a patch that doesn't use magic numbers :P
I didn't hit the problem described in bpo-4313 with this one, and
PythonCmd should be doing this anyway, but ideally we should move to
Tcl_CreateObjCommand.