gh-119786: added InternalDocs/generators.md #128524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
reviewed
Jan 5, 2025
Co-authored-by: Tomas R. <[email protected]>
markshannon
reviewed
Jan 14, 2025
Member
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
This seems to cover the semantics, which I think we can assume the reader knows, more than the implementation.
Some things I think are worth covering:
- The location of the frame, specifically how it moves from generator to frame object if the frame object outlives the generator
- Similarities and differences between
yieldandreturn(you already cover this) - Generator construction (
RETURN_GENERATOR) - Specialization of
FOR_ITERfor generators - How
yield fromis implemented - Why
CLEANUP_THROWneeds to exist.
markshannon
reviewed
Jan 15, 2025
Member
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
A useful addition to the docs.
I have a few more suggestions, but this mostly looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.