Skip to content

[3.7] bpo-41944: No longer call eval() on content received via HTTP in the CJK codec tests (GH-22566) #22578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ned-deily merged 1 commit into from
Oct 20, 2020
Merged

[3.7] bpo-41944: No longer call eval() on content received via HTTP in the CJK codec tests (GH-22566) #22578

ned-deily merged 1 commit into from
Oct 20, 2020

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 6, 2020 •
edited by bedevere-bot
Loading

(cherry picked from commit 2ef5caa)

Co-authored-by: Serhiy Storchaka [email protected]

https://bugs.python.org/issue41944

@serhiy-storchaka @miss-islington
bpo-41944: No longer call eval() on content received via HTTP in the …
db0cf34 
…CJK codec tests (pythonGH-22566)

(cherry picked from commit 2ef5caa)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Oct 6, 2020
Merged
@bedevere-bot bedevere-bot added type-security A security issue tests Tests in the Lib/test dir awaiting review labels Oct 6, 2020
@miss-islington
Copy link
Contributor Author

miss-islington commented Oct 6, 2020

@serhiy-storchaka: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

miss-islington commented Oct 6, 2020

@serhiy-storchaka: Status check is done, and it's a success ✅ .

vstinner
vstinner approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

miss-islington commented Oct 6, 2020

@serhiy-storchaka: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Oct 6, 2020

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@vstinner
Copy link
Member

vstinner commented Oct 6, 2020

@ned-deily: Would you mind to merge this security fix into 3.7?

@vstinner vstinner mentioned this pull request Oct 8, 2020
Closed
@ned-deily ned-deily merged commit 43e5231 into python:3.7 Oct 20, 2020
@miss-islington miss-islington deleted the backport-2ef5caa-3.7 branch October 20, 2020 02:38
@serhiy-storchaka serhiy-storchaka mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@miss-islington @vstinner @ned-deily @the-knights-who-say-ni @bedevere-bot @serhiy-storchaka