bpo-45401: Fix a resource warning in test_logging #28864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Oh, you created a fix almost the same time than me :-D But you was faster, I close my fix: PR #28865. |
vstinner
approved these changes
Oct 11, 2021
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
I plan to backport the isfile() change with this change to 3.10, and then backport the 3.10 change to 3.9.
Member
Author
|
Only on a half of minute! 🏁 |
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
GH-28872 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 11, 2021
(cherry picked from commit 15188b1) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 11, 2021
(cherry picked from commit 15188b1) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-28873 is a backport of this pull request to the 3.9 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 12, 2021
(cherry picked from commit 15188b1) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 12, 2021
(cherry picked from commit 15188b1) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45401