bpo-31961: subprocess.run() now accepts path-like args #4329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks with pathlike objects
to better explain it. there may be better ways to write this, but this plus the comments will do for now. I don't really _like_ catching TypeError. It's too generic.
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Feb 26, 2018
…)" This reverts commit dd42cb7.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 27, 2018
…)" (pythonGH-5912) * Revert "bpo-31961: subprocess now accepts path-like args (pythonGH-4329)" This reverts commit dd42cb7. (cherry picked from commit be50a7b) Co-authored-by: Serhiy Storchaka <[email protected]>
ned-deily
pushed a commit
that referenced
this pull request
Feb 27, 2018
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Feb 28, 2018
…honGH-4329)" (python#5912)" This reverts commit be50a7b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per bpo-31961, if the args argument of subprocess.run() was a path-like object, TypeError would raised. If the args argument was a sequence where the first element was a path-like object, it would work on posix, but not on windows. Both of these issues are resolved in this PR.
https://bugs.python.org/issue31961