Fix inheriting from generic @frozen attrs class #15700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ikonst
commented
Jul 28, 2023
| # This variable belongs to a super class so create new Var so we | ||
| # can modify it. | ||
| var = Var(attribute.name, ctx.cls.info[attribute.name].type) | ||
| var = Var(attribute.name, attribute.init_type) |
Contributor
Author
There was a problem hiding this comment.
Actually, this is problematic with converters, e.g.
def converter(s: str) -> int:
return int(s)
@attrs.define
class C:
x: int = attrs.field(converter=converter)The attribute.init_type will be str here :(
Contributor
Author
There was a problem hiding this comment.
Ahh, nm, by the time it's deserialized, it's int again (there's also converter_init_type).
Contributor
Author
|
@hauntsaninja can take a look? |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
approved these changes
Aug 12, 2023
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Not the most familiar with attrs plugin, but this seems reasonable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15658.