IssetOnPropertyObjectToPropertyExistsRector too eager

[victorlap]

Bug Report

Subject	Details
Rector version	Rector 2.0.11

The IssetOnPropertyObjectToPropertyExistsRector changes code while it shouldn't.

Minimal PHP Code Causing Issue

https://getrector.com/demo/fc241ad4-ac82-4120-bfe7-27ffc62ac965

-        if (! isset($values['_identity']->value)) {
+        if ($values['_identity']->value === null) {

Expected Behaviour

Rector should leave this code snippet, or allow for the array key to not exist, like:

-        if (! isset($values['_identity']->value)) {
+        if ($values['_identity']?->value === null) {

[TomasVotruba]

Thank you for your report and demo link!

We'll need a failing test case in a pull-request, so we have it covered in Rector.
You can click "Create a Test" button at demo page.

[victorlap]

Thanks for the quick reply, I've added the fixture

[github-actions]

This issue has been automatically locked because it has been closed for 150 days. Please open a new issue if you have a similar problem.