Allow ES6 native Promises and other promise implementations

[analog-nico]

As suggested by @silverbp in issue #64 users of Request-Promise probably would like to use ES6 native Promises instead of Bluebird or even other promise implementations.

Waiting for +1's with the preferred promise implementation.

[vgoloviznin]

+1 for native

[mikeal]

While Bluebird is still faster than native promises they lack the features we've added to core for global error handling in promises. If people still want Bluebird on the frontend they'll get them injected by their compile toolchain.

[analog-nico]

Hi @mikeal good point regarding the compile toolchain. I assume from that that native promises - and not Bluebird - lack the features? (Sorry, the grammar of your first sentence confuses me non-native speaker.;)

Which features in core are you actually referring to?

[mikeal]

Here's the first one https://iojs.org/api/process.html#process_event_unhandledrejection and there may be another one eventually for a totally unhandled promise. These are only features in native promises as these require low level vm hooks.

[analog-nico]

Thanks for the pointer! Also offering native promise support seems unquestionable to me now.

[MarkHerhold]

+1 for native, so long as we can override with our own version of Bluebird/whatever.

The native-or-bluebird module would also be an attractive option (instead of any-promise) and would align more with the history of this project.

request-promise is on bluebird 2, where bluebird 3 is now out so I am in favor of decoupling in order to make selecting the promise implementation more flexible.

[analog-nico]

Thanks for the pointer to native-or-bluebird @MarkHerhold ! Indeed, the next version will at least support native and Bluebird.

[gillesdemey]

+1 for using native-or-bluebird, but many developers will probably want to choose which one specifically.

[tonylukasavage]

+1 for native, as I would have pulled this into our project immediately if it supported native Promises.

[hildjj]

native-or-bluebird works for me. Note to @mikeal 's point about unhandledRejection, that seems to work on bluebird 3.1.1, not sure when it was added:

var bb = require('bluebird');
process.on('unhandledRejection', e => console.log('unhandled', e));
new bb.Promise((res,rej) => rej('foo'));

Output:

unhandled foo

[iggycoloma]

+1 for native support, along with the caveats above about letting people choose which Promise implementation they wish to use.

[sherdeadlock]

any-promise
It supports es6-promise, bluebird, rsvp, when, q.

[eilgin]

👍 for having native promises supported.