Use Vec::drain() to move thread out of the vector #3248 #3249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-21
changed the title
2 tasks
chriskrycho
reviewed
Apr 18, 2024
Contributor
chriskrycho
left a comment
chriskrycho
left a comment
There was a problem hiding this comment.
-
I like this directionally, and so am flagging it as one we might integrate as we do the revisions for the next edition of the book. I am not merging it at this point because we might (or might not! It’s not clear yet) make more sweeping revisions to this part.
-
It looks like there are a number of extraneous changes around the listings’ HTML files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Vec::drainmethod which allows to move elements out of the vector. Then wrappingthreadintoOptionis not needed.