Event List empty

[olesq]

Event List showing as empty for editing purposes although all events displaying as normal in calendar etc. Total of events showing correctly at top of page. Seems to have happened since 'group by' fix.
WP-eventlist.docx

[stephenharris]

Hi @olesq would you be able to install the Query Monitor plugin ( https://en-gb.wordpress.org/plugins/query-monitor/) and leave a comment here with the main SQL query for events (involving eo_events table)?

I've not been able to replicate this issue, so I'm wondering if its down to a MySQL version, plugin configuration or a conflict with another plugin.

[olesq]

Hi Stephen Added Query Monitor Plugin as requested and when I then tried to list events it immediately flagged up a database query error which refers to eo_events table. I have attached a screen print of this. if you need more output from Query Monitor please let me know what you need - I have not used it before. Thanks Olly

…

On 13 March 2018 at 17:09, Stephen Harris ***@***.***> wrote: Hi @olesq <https://github.com/olesq> would you be able to install the Query Monitor plugin ( https://en-gb.wordpress.org/plugins/query-monitor/) and leave a comment here with the main SQL query for events (involving eo_events table)? I've not been able to replicate this issue, so I'm wondering if its down to a MySQL version, plugin configuration or a conflict with another plugin. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#432 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AjmZEioG1E578TJArrS10UBH1slMRRN1ks5td_1EgaJpZM4SoWg-> .

[stephenharris]

@olesq I don't think attachments work when replying by email. You can upload the image by visiting this issue in a web browser.

[olesq]

Here is screen print of output from Query Monitor
WP-eventlist-QM-eo-events-join.docx

[stephenharris]

Thanks @olesq - that's helped a lot in getting to the bottom of this. The fix for #430 was to join the table against itself which results in a (potential) N^2 join where N is the number of rows in the eo_events table. If you have enough rows that is set larger than you SQL server's MAX_JOIN_SIZE then you'll get this error.

The solution is two fold - first, the plug-in will explicitly tell the MySQL server that 'big joins are ok' (SET SQL_BIG_SELECTS=1;). It will then ignore the MAX_JOIN_SIZE limit, and fix the immediate issue.

The MAX_JOIN_SIZE is there to prevent applications from crashing because they run a join too large for the mysql server to handle. Therefore, the second change is that the admin event list page will run a different query when grouping the event dates; a more efficient one, which is possible because it doesn't matter how it groups the dates.

Therefore, out of the box the plug-in won't run the (potentially) large JOIN query, and will do only when 'grouping occurrences' in the settings page, or shortcode/widget settings - is enabled.

There'll be an update in the next few days - if you are able to test fix ahead of that release, I would be very grateful.

[olesq]

Hi Stephen Happy to help testing if I can - not sure how I can do this ahead of your release? Olly

…

On Wed, 14 Mar 2018 21:20 Stephen Harris, ***@***.***> wrote: Thanks @olesq <https://github.com/olesq> - that's helped a lot in getting to the bottom of this. The fix for #430 <#430> was to join the table against itself which results in a (potential) N^2 join where N is the number of rows in the eo_events table. If you have enough rows that is set larger than you SQL server's MAX_JOIN_SIZE then you'll get this error. The solution is two fold - first, the plug-in will explicitly tell the MySQL server that 'big joins are ok' (SET SQL_BIG_SELECTS=1;). It will then ignore the MAX_JOIN_SIZE limit, and fix the immediate issue. The MAX_JOIN_SIZE is there to prevent applications from crashing because they run a join too large for the mysql server to handle. Therefore, the second change is that the admin event list page will run a different query when grouping the event dates; a more efficient one, which is possible because it doesn't matter how it groups the dates. Therefore, out of the box the plug-in won't run the (potentially) large JOIN query, and will do only when 'grouping occurrences' in the settings page, or shortcode/widget settings - is enabled. There'll be an update in the next few days - if you are able to test fix ahead of that release, I would be very grateful. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#432 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AjmZEgbcoJ_3Cvt-gwoMChDsqR4JeAVIks5teYm0gaJpZM4SoWg-> .

[olesq]

Hi Stephen Just wondering if fix will available soon - or have you hit some problems? Thanks Olly

…

On 15 March 2018 at 20:05, O Leonard ***@***.***> wrote: Hi Stephen Happy to help testing if I can - not sure how I can do this ahead of your release? Olly On Wed, 14 Mar 2018 21:20 Stephen Harris, ***@***.***> wrote: > Thanks @olesq <https://github.com/olesq> - that's helped a lot in > getting to the bottom of this. The fix for #430 > <#430> was to > join the table against itself which results in a (potential) N^2 join > where N is the number of rows in the eo_events table. If you have enough > rows that is set larger than you SQL server's MAX_JOIN_SIZE then you'll > get this error. > > The solution is two fold - first, the plug-in will explicitly tell the > MySQL server that 'big joins are ok' (SET SQL_BIG_SELECTS=1;). It will > then ignore the MAX_JOIN_SIZE limit, and fix the immediate issue. > > The MAX_JOIN_SIZE is there to prevent applications from crashing because > they run a join too large for the mysql server to handle. Therefore, the > second change is that the admin event list page will run a different query > when grouping the event dates; a more efficient one, which is possible > because it doesn't matter how it groups the dates. > > Therefore, out of the box the plug-in won't run the (potentially) large > JOIN query, and will do only when 'grouping occurrences' in the settings > page, or shortcode/widget settings - is enabled. > > There'll be an update in the next few days - if you are able to test fix > ahead of that release, I would be very grateful. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#432 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AjmZEgbcoJ_3Cvt-gwoMChDsqR4JeAVIks5teYm0gaJpZM4SoWg-> > . >

[stephenharris]

HI @olesq sorry for the delay - that should be released now.