Skip to content

feat: added base64 SQL function #30625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dapan1121 merged 3 commits into from
Apr 17, 2025
Merged

feat: added base64 SQL function #30625

dapan1121 merged 3 commits into from
Apr 17, 2025

Conversation

@aestriplex
Copy link
Contributor

@aestriplex aestriplex commented Apr 2, 2025

Description

This PR adds the base64 SQL function for strings and byte arrays

此 PR 新增了字串和位元組數組的 base64 SQL 函數

Checklist

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

dapan1121
dapan1121 reviewed Apr 7, 2025
View reviewed changes
Copy link
Contributor

@dapan1121 dapan1121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR should be applied to branch 3.0

Simon9997
Simon9997 reviewed Apr 7, 2025
View reviewed changes
Simon9997
Simon9997 reviewed Apr 7, 2025
View reviewed changes
Simon9997
Simon9997 reviewed Apr 7, 2025
View reviewed changes
@aestriplex aestriplex requested review from a team and feici02 as code owners April 7, 2025 08:44
@aestriplex aestriplex changed the base branch from 3.3.6 to 3.0 April 7, 2025 08:45
@tomchon
Copy link
Contributor

tomchon commented Apr 8, 2025

@aestriplex Just a gentle reminder that merging the 3.0 branch again might be needed to trigger the CI workflow for merging into 3.0. Thank you!

@aestriplex
Copy link
Contributor Author

aestriplex commented Apr 8, 2025

@aestriplex Just a gentle reminder that merging the 3.0 branch again might be needed to trigger the CI workflow for merging into 3.0. Thank you!

@tomchon (cc. @Simon9997) Apparently there is still a test that fails

./test.sh -f tsim/query/udfpy.sim

but now my branch is one exact commit ahead of upstream/3.0

Screenshot

@tomchon
Copy link
Contributor

tomchon commented Apr 8, 2025

@aestriplex This issue is not related to this PR. It is already being tracked and resolved internally.

@aestriplex Just a gentle reminder that merging the 3.0 branch again might be needed to trigger the CI workflow for merging into 3.0. Thank you!

@tomchon (cc. @Simon9997) Apparently there is still a test that fails

./test.sh -f tsim/query/udfpy.sim

but now my branch is one exact commit ahead of upstream/3.0

Screenshot

@Simon9997 Simon9997 requested a review from dapan1121 April 9, 2025 01:02
Simon9997
Simon9997 reviewed Apr 10, 2025
View reviewed changes
Simon9997
Simon9997 reviewed Apr 15, 2025
View reviewed changes
@dapan1121 dapan1121 merged commit deb6c8b into taosdata:3.0 Apr 17, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Simon9997 Simon9997 Simon9997 left review comments

@dapan1121 dapan1121 dapan1121 approved these changes

@guanshengliang guanshengliang Awaiting requested review from guanshengliang guanshengliang is a code owner

@zitsen zitsen Awaiting requested review from zitsen zitsen is a code owner

@hzcheng hzcheng Awaiting requested review from hzcheng hzcheng is a code owner

@feici02 feici02 Awaiting requested review from feici02

Assignees

No one assigned

Labels

from community

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aestriplex @tomchon @dapan1121 @Simon9997 @jiacy-jcy