Freemine.cmake.3.0 #30663
Merged
Freemine.cmake.3.0 #30663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…right after DEP_ext_libuv
1. ext_lzma2 is only used by Linux 2. fix bug in taosd-ci-build.yml
…er than .externals
…ch(freemine.cmake.3.0) has not include taos_fetch_fields_e from upstream
…1,2} from CMakeLists.txt(s)
facetosea
reviewed
Apr 16, 2025
| TARGET_LINK_LIBRARIES( | ||
| joinTests | ||
| PRIVATE os util common executor gtest_main qcom function planner scalar nodes vnode | ||
| PRIVATE PRIVATE os util common executor qcom function planner scalar nodes vnode |
Contributor
Author
There was a problem hiding this comment.
this is executable target, PRIVATE/PUBLIC does not make big difference, i guess.
Contributor
Author
There was a problem hiding this comment.
ok, it's typo, double PRIVATE
source/client/wrapper/CMakeLists.txt
Outdated
| ) | ||
|
|
||
| add_library(${TAOS_LIB_STATIC} STATIC ${WRAPPER_SRC}) | ||
| add_dependencies(${TAOS_LIB_STATIC} ${TAOS_NATIVE_LIB_STATIC}) |
Contributor
Author
There was a problem hiding this comment.
seems need to be removed
| run-tests-on-linux: | ||
| uses: taosdata/.github/.github/workflows/run-tests-on-linux.yml@main | ||
| # NOTE: using tomchon-patch-3 branch for the moment | ||
| uses: taosdata/.github/.github/workflows/run-tests-on-linux.yml@tomchon-patch-3 |
| int err = uv_dlopen(libPath, pLib); | ||
| if (err != 0) { | ||
| fnError("can not load library %s. error: %s", libPath, uv_strerror(err)); | ||
| fnError("can not load library %s. error: %s, %s", libPath, uv_strerror(err), pLib->errmsg); |
Contributor
There was a problem hiding this comment.
pLib 可能为空，改为 pLib ? "" : pLib->errmsg
Contributor
Author
There was a problem hiding this comment.
392: TAOS_UDF_CHECK_PTR_RCODE(libPath, pLib, funcName, func);
has already check?
| -v ${REP_REAL_PATH}/community/contrib/zlib/:${REP_DIR}/community/contrib/zlib \ | ||
| -v ${REP_REAL_PATH}/community/contrib/zstd/:${REP_DIR}/community/contrib/zstd \ | ||
| --rm --ulimit core=-1 taos_test:v1.0 sh -c "cd $REP_DIR; rm -rf debug; mkdir -p debug; cd debug; cmake .. -DBUILD_HTTP=false -DBUILD_TOOLS=true -DBUILD_TEST=ON -DWEBSOCKET=true -DBUILD_TAOSX=false -DJEMALLOC_ENABLED=OFF -DCMAKE_EXPORT_COMPILE_COMMANDS=1 ;make -j|| exit 1" | ||
| --rm --ulimit core=-1 taos_test:v1.0 sh -c "cd $REP_DIR; rm -rf debug; mkdir -p debug; cd debug; cmake .. -DBUILD_HTTP=false -DBUILD_TOOLS=true -DBUILD_TEST=ON -DWEBSOCKET=true -DBUILD_TAOSX=false -DJEMALLOC_ENABLED=OFF -DCMAKE_EXPORT_COMPILE_COMMANDS=1 ;make VERBOSE=1 -j|| exit 1" |
| -v ${REP_REAL_PATH}/community/contrib/zlib/:${REP_DIR}/community/contrib/zlib \ | ||
| -v ${REP_REAL_PATH}/community/contrib/zstd/:${REP_DIR}/community/contrib/zstd \ | ||
| --rm --ulimit core=-1 taos_test:v1.0 sh -c "cd $REP_DIR; rm -rf debug; mkdir -p debug; cd debug; cmake .. -DBUILD_HTTP=internal -DBUILD_TOOLS=true -DBUILD_TEST=ON -DWEBSOCKET=true -DBUILD_SANITIZER=1 -DTOOLS_SANITIZE=true -DCMAKE_BUILD_TYPE=Debug -DTOOLS_BUILD_TYPE=Debug -DBUILD_TAOSX=false -DJEMALLOC_ENABLED=OFF; make -j|| exit 1 " | ||
| --rm --ulimit core=-1 taos_test:v1.0 sh -c "cd $REP_DIR; rm -rf debug; mkdir -p debug; cd debug; cmake .. -DBUILD_HTTP=internal -DBUILD_TOOLS=true -DBUILD_TEST=ON -DWEBSOCKET=true -DBUILD_SANITIZER=1 -DTOOLS_SANITIZE=true -DCMAKE_BUILD_TYPE=Debug -DTOOLS_BUILD_TYPE=Debug -DBUILD_TAOSX=false -DJEMALLOC_ENABLED=OFF; make VERBOSE=1 -j|| exit 1 " |
tests/parallel_test/run.sh
Outdated
| if [ $ret -eq 0 ]; then | ||
| break | ||
| fi | ||
| echo ========================== |
tests/parallel_test/run_case.sh
Outdated
| fi | ||
|
|
||
| if [ $ent -eq 0 ]; then | ||
| echo "community edition init env" |
Contributor
There was a problem hiding this comment.
该文件中的所有 echo 及其他修改，需要恢复
tests/script/sh/compile_udf.sh
Outdated
|
|
||
| # NOTE: debug for the moment | ||
| date | ||
| pwd |
Contributor
There was a problem hiding this comment.
该文件中的所有 echo 及其他修改，是否需要恢复
_GNU_SOURCE with guard
guanshengliang
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#29936
Checklist
Please check the items in the checklist if applicable.