Skip to content

Conversation

@Simon9997
Copy link
Contributor

Description

Please briefly describe the code changes in this pull request.

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

@Simon9997 Simon9997 requested review from Copilot and removed request for dapan1121, guanshengliang and hzcheng April 29, 2025 03:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes legacy “stream event type” functionality and refactors the processing of SCMCreateStreamReq by adding new fields and adjusting serialization/deserialization flows. Key changes include:

  • Updates in SCMCreateStreamReq encoding/decoding (e.g. new fields streamId, flags, tsmaId, placeHolderBitmap, and expanded sliding trigger parameters).
  • Removal of legacy stream node tests and related node types, along with updates to built-in function classifications.
  • Cleaning up client and parser structures by removing deprecated fields (e.g. streamRunHistory) and stream‐related fields in planner and nodes headers.

Reviewed Changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.

Show a summary per file
File Description
source/libs/nodes/test/nodesCloneTest.cpp Removed test cases for stream session/window nodes; verify test coverage.
source/libs/nodes/src/nodesUtilFuncs.c Removed calls to free SCMCreateStreamReq in node destruction; check memory management.
source/libs/nodes/src/nodesMsgFuncs.c Deleted functions related to stream event type and stream partition nodes.
source/libs/nodes/src/nodesCodeFuncs.c Adjusted JSON conversion keys and removed outdated stream event type code.
source/libs/function/src/functionMgt.c & builtins.c Updated built-in function classifications; removal of forbid-stream flag.
source/common/src/msg/streamMsg.c Updated SCMCreateStreamReq serialization/deserialization with new fields.
source/client/src/clientMain.c & related headers Removed deprecated field streamRunHistory and cleaned up API struct initializations.
Comments suppressed due to low confidence (4)

source/libs/nodes/test/nodesCloneTest.cpp:261

  • The removal of test cases for stream session/window nodes is significant; please ensure that the new SCMCreateStreamReq functionality is covered by updated tests elsewhere.
TEST_F(NodesCloneTest, physiStreamSemiSessionWinodw) { ... }

source/libs/nodes/src/nodesUtilFuncs.c:1553

  • The explicit freeing of pReq has been removed here; please confirm that memory allocated for SCMCreateStreamReq is now handled appropriately elsewhere to avoid potential memory leaks.
tFreeSCMCreateStreamReq(pStmt->pReq);

source/libs/function/src/builtins.c:2049

  • [nitpick] The built-in function classifications have been updated by removing the FUNC_MGT_FORBID_STREAM_FUNC flag; please double-check that this change aligns with intended restrictions for stream functions.
.classification = FUNC_MGT_AGG_FUNC | FUNC_MGT_FORBID_STREAM_FUNC | FUNC_MGT_FORBID_SYSTABLE_FUNC,

source/common/src/msg/streamMsg.c:1527

  • New sliding trigger fields (intervalUnit, slidingUnit, offsetUnit, soffsetUnit, and precision) have been added; please verify that the encoding order exactly matches the decoding order to avoid data inconsistencies.
TAOS_CHECK_EXIT(tEncodeI8(pEncoder, pReq->trigger.sliding.intervalUnit));

@Simon9997 Simon9997 force-pushed the feat/TS-6100-smj branch 2 times, most recently from a95f6cb to cc8c6d3 Compare April 29, 2025 06:55
support placeHolderBitmap and interval offset in stream trigger.
remove useless code.
@Simon9997 Simon9997 merged commit 26bde0d into feat/TS-6100-3.0 Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants