fix: update library file paths in makeclient.sh to remove version suffixes for consistency #31128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feici02
approved these changes
May 18, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the library file naming in the packaging scripts by removing version suffixes from source paths and standardizing the destination filenames with version suffixes.
- In
makepkg.sh, thepkg_*variables no longer include thelib/directory prefix. - In
makeclient.sh, the source library variables drop the version suffix and the copy commands now rename outputs using newpkg_*variables. - Copying of the WS library is now unconditional, and all copied files are placed under
driver/with versioned filenames.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| makepkg.sh | Removed lib/ prefix from pkg_* variables for packaged paths |
| makeclient.sh | Source library vars unversioned; updated cp commands to use pkg_* names |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please briefly describe the code changes in this pull request.
Checklist
Please check the items in the checklist if applicable.