Skip to content

Conversation

@Simon9997
Copy link
Contributor

@Simon9997 Simon9997 commented Jul 29, 2025

Description

Please briefly describe the code changes in this pull request.

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reopens previously disabled unit tests by removing TODO comments and uncommenting test code related to stream functionality. The changes systematically re-enable test coverage that was temporarily disabled for stream-related features.

  • Uncommented test cases across multiple test files in the planner and parser libraries
  • Restored test functionality for various SQL operations including GROUP BY, SELECT, ALTER, and stream-related commands
  • Updated mock catalog and message type definitions to support the re-enabled tests

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
source/libs/planner/test/planSubqueryTest.cpp Re-enabled doubleGroupBy test case
source/libs/planner/test/planStateTest.cpp Restored selectFunc test for STATE_WINDOW clause
source/libs/planner/test/planOptimizeTest.cpp Uncommented eliminateProjection and LastRowScan tests
source/libs/planner/test/planIntervalTest.cpp Re-enabled fill test for INTERVAL queries
source/libs/planner/test/planGroupByTest.cpp Restored basic GROUP BY and selectFunc tests
source/libs/planner/test/planBasicTest.cpp Uncommented whereClause, caseWhen, lastRowFuncWithoutCache, and indefiniteRowsFunc tests
source/libs/parser/test/parShowToUseTest.cpp Re-enabled showStreams test
source/libs/parser/test/parSelectTest.cpp Restored expression, multiResFunc, timelineFunc, selectFunc, and other test functions
source/libs/parser/test/parInsertTest.cpp Uncommented single table insert tests
source/libs/parser/test/parInitialDTest.cpp Re-enabled describe test
source/libs/parser/test/parInitialCTest.cpp Restored createView and createStable tests
source/libs/parser/test/parAlterToBalanceTest.cpp Uncommented alterTable and alterTableSemanticCheck tests
source/libs/parser/test/mockCatalog.cpp Updated stream table structure and added catalogRemoveTableRelatedMeta function
source/libs/parser/src/parTokenizer.c Added DELETE_MARK token
source/common/test/tmsgTest.cpp Re-enabled msg_type_compatibility_test
source/common/test/msgTypeTable.ini Updated message type definitions for stream operations
Comments suppressed due to low confidence (2)

source/libs/parser/test/mockCatalog.cpp:229

  • The table name has been changed from "t1" to "stream_t1". This renaming should be consistent throughout the codebase to avoid breaking references to the original table name in tests.
    ITableBuilder& builder = mcs->createTableBuilder(db, "stream_t1", TSDB_NORMAL_TABLE, 3, 0)

source/libs/parser/test/mockCatalog.cpp:237

  • The table name has been changed from "t2" to "stream_t2". This renaming should be consistent throughout the codebase to avoid breaking references to the original table name in tests.
    ITableBuilder& builder = mcs->createTableBuilder(db, "stream_t2", TSDB_NORMAL_TABLE, 4, 0)

@dapan1121 dapan1121 merged commit 82eb54b into main Jul 30, 2025
20 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants