test: [TS-6100] Reopen stream ut #32396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon9997
requested review from
dapan1121,
guanshengliang and
hzcheng
as code owners
Simon9997
force-pushed
the
feat/TS-6100-3.0-UT
branch
from
d0565b8 to
99022d6
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes two bugs in the codebase: adds missing handling for virtual stable reference databases in the mock catalog service and corrects JSON serialization issues in the nodes module.
- Adds support for
pVStbRefDbshandling in the mock catalog service - Fixes incorrect JSON key constant and missing return code check
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| source/libs/parser/test/mockCatalogService.cpp | Implements getAllVstbRefDbs method and integrates it into catalog metadata retrieval |
| source/libs/nodes/src/nodesCodeFuncs.c | Corrects JSON key constant from "DataType" to "TagExpr" and fixes missing error code handling |
dapan1121
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reopen create stream unit test
Checklist
Please check the items in the checklist if applicable.