-
Notifications
You must be signed in to change notification settings - Fork 5k
docs: update release note for 3.3.8.1 in office web #33216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @feici02, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on preparing for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the version number to 3.3.8.1 across various documentation files and adds the corresponding release notes. The changes are generally correct and align with the goal of preparing for a new release. I've identified a few minor issues, including duplicated attributes in some components and opportunities to improve the clarity and consistency of the release notes.
docs/zh/08-operation/03-install.md
Outdated
| <TabItem label="rpm 安装" value="rpminst"> | ||
| 1. 从列表中下载获得 rpm 安装包: | ||
| <PkgListV37 productName="TDengine TSDB-OSS" version="3.3.8.0" platform="Linux-Red Hat" arch="x64" pkgType="Server" pkgType="Server"/> | ||
| <PkgListV37 productName="TDengine TSDB-OSS" version="3.3.8.1" platform="Linux-Red Hat" arch="x64" pkgType="Server" pkgType="Server"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pkgType attribute is duplicated in this <PkgListV37> component. Please remove one of them to avoid potential issues.
| <PkgListV37 productName="TDengine TSDB-OSS" version="3.3.8.1" platform="Linux-Red Hat" arch="x64" pkgType="Server" pkgType="Server"/> | |
| <PkgListV37 productName="TDengine TSDB-OSS" version="3.3.8.1" platform="Linux-Red Hat" arch="x64" pkgType="Server"/> |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
tomchon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update release note for 3.3.8.1